Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese translation #306

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Japanese translation #306

wants to merge 4 commits into from

Conversation

Kamesuta
Copy link
Contributor

@Kamesuta Kamesuta commented Oct 6, 2023

Changes

  • Added Japanese translation for the launcher interface
  • Fixed CSS to prevent Japanese text from breaking in the middle of a word

@dscalzi
Copy link
Owner

dscalzi commented Oct 7, 2023

My only concern is how do we keep these up to date?

@GeekCornerGH
Copy link
Contributor

My only concern is how do we keep these up to date?

@dscalzi Fallback to english when some translations are missing

@xllifi
Copy link

xllifi commented Oct 12, 2023

My only concern is how do we keep these up to date?

more like why

this launcher is not meant to be used stock
you edit something anyway, so making a custom translation shouldn't be a problem

dscalzi
dscalzi reviewed Oct 14, 2023
View reviewed changes
app/assets/lang/ja_JP.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscalzi dscalzi dscalzi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kamesuta @dscalzi @GeekCornerGH @xllifi